aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAlberto Bertogli <albertito@blitiri.com.ar>2020-05-25 03:04:55 +0200
committerAlberto Bertogli <albertito@blitiri.com.ar>2020-05-25 03:04:55 +0200
commite2155f6b3327c35670a7c71fbac36b071f7f28c0 (patch)
tree458f6506a9265bb056036d5e3307e019cad8640a
parentaee18d0edd88b9db07c3cfb5c13d9889ffac94c1 (diff)
downloadgit-arr-fork-e2155f6b3327c35670a7c71fbac36b071f7f28c0.zip
Remove unused/unnecessary code
This patch removes some code that is unused and/or unnecessary. Most of it is left over from previous situations, but is no longer needed.
-rw-r--r--git.py17
1 files changed, 3 insertions, 14 deletions
diff --git a/git.py b/git.py
index 6cec1cd..3fa160c 100644
--- a/git.py
+++ b/git.py
@@ -64,17 +64,15 @@ def run_git(
class GitCommand(object):
"""Convenient way of invoking git."""
- def __init__(self, path: str, cmd: str, *args, **kwargs):
+ def __init__(self, path: str, cmd: str):
self._override = True
self._path = path
self._cmd = cmd
- self._args: List[str] = list(args)
+ self._args: List[str] = []
self._kwargs: Dict[str, str] = {}
self._stdin_buf: Optional[bytes] = None
self._raw = False
self._override = False
- for k, v in kwargs:
- self.__setattr__(k, v)
def __setattr__(self, k, v):
if k == "_override" or self._override:
@@ -93,11 +91,9 @@ class GitCommand(object):
self._raw = b
self._override = False
- def stdin(self, s: Union[str, bytes]):
+ def stdin(self, s: bytes):
"""Sets the contents we will send in stdin."""
self._override = True
- if isinstance(s, str):
- s = s.encode("utf8")
self._stdin_buf = s
self._override = False
@@ -136,9 +132,6 @@ class smstr:
self.url = urllib.request.pathname2url(s)
self.html = self._to_html()
- def __cmp__(self, other):
- return cmp(self.raw, other.raw)
-
# Note we don't define __repr__() or __str__() to prevent accidental
# misuse. It does mean that some uses become more annoying, so it's a
# tradeoff that may change in the future.
@@ -236,10 +229,6 @@ class Repo:
for obj_id, _, ref in refs:
yield ref[len("refs/tags/") :], obj_id
- def tag_names(self):
- """Get the names of the tags."""
- return (name for name, _ in self.tags())
-
def commit_ids(self, ref, limit=None):
"""Generate commit ids."""
cmd = self.cmd("rev-list")