diff options
| author | Eric Sunshine <sunshine@sunshineco.com> | 2015-01-13 10:57:13 +0100 |
|---|---|---|
| committer | Alberto Bertogli <albertito@blitiri.com.ar> | 2015-01-13 20:51:44 +0100 |
| commit | 09c2f33f5a1f7137d50b3638e1a3f937e0701a6e (patch) | |
| tree | 37aa3b557931b053616dabe086cf7fe84647ba86 /views | |
| parent | 58037e57c591b1c55594a0adb637d1880bfacaee (diff) | |
| download | git-arr-fork-09c2f33f5a1f7137d50b3638e1a3f937e0701a6e.zip | |
blob: render binary blob summary information rather than raw content
Binary blobs are currently rendered as raw data directly into the HTML
output, looking much like "line noise". This is rarely, if ever,
meaningful, and consumes considerable storage space since the entire raw
blob content is embedded in the generated HTML file.
Address this issue by instead emitting summary information about the
blob, such as its classification ("binary") and its size. Other
information can be added as needed.
As in Git itself, a blob is considered binary if a NUL is present in the
first ~8KB.
Signed-off-by: Eric Sunshine <sunshine@sunshineco.com>
Signed-off-by: Alberto Bertogli <albertito@blitiri.com.ar>
Diffstat (limited to 'views')
| -rw-r--r-- | views/blob.html | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/views/blob.html b/views/blob.html index 1849260..4526c99 100644 --- a/views/blob.html +++ b/views/blob.html @@ -41,6 +41,14 @@ % if can_embed_image(repo, fname.unicode): {{!embed_image_blob(fname.raw, blob.raw_content)}} +% elif is_binary(blob.raw_content): +<table class="nice"> + <tr> + <td> + binary — {{'{:,}'.format(len(blob.raw_content))}} bytes + </td> + </tr> +</table> % elif can_markdown(repo, fname.unicode): {{!markdown_blob(blob.utf8_content)}} % elif can_colorize(blob.utf8_content): |