diff options
author | Eric Sunshine <sunshine@sunshineco.com> | 2015-01-13 10:57:09 +0100 |
---|---|---|
committer | Alberto Bertogli <albertito@blitiri.com.ar> | 2015-01-13 20:51:44 +0100 |
commit | 0ba89d75e6e26bf14f5b6cfb6526e601f7ad7e2d (patch) | |
tree | 2c4ec4fd595c0893f4e8d5742f08dee766d59ce3 /views | |
parent | 6b83e32bc1cc6adb831631e30de59b026971534a (diff) | |
download | git-arr-fork-0ba89d75e6e26bf14f5b6cfb6526e601f7ad7e2d.zip |
git.py: introduce Blob abstraction
Some blob representations (such as embedded images) require raw blob
content, however, the 'blob' view is unconditionally handed cooked
(utf8-encoded) content, thus representations which need raw content are
forced to reload the blob in raw form, which is ugly and expensive (due
to shelling out to git-cat-file a second time).
The ultimate goal is to eliminate the wasteful blob reloading when raw
content is needed. As a first step, introduce a Blob abstraction to be
returned by Repo.blob() rather than the cooked content. A subsequent
change will flesh out Blob, allowing it to return raw or cooked content
on demand without the client having to specify one or the other when
invoking Repo.blob().
Signed-off-by: Eric Sunshine <sunshine@sunshineco.com>
Signed-off-by: Alberto Bertogli <albertito@blitiri.com.ar>
Diffstat (limited to 'views')
-rw-r--r-- | views/blob.html | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/views/blob.html b/views/blob.html index e44ff99..f744cd9 100644 --- a/views/blob.html +++ b/views/blob.html @@ -42,12 +42,12 @@ % if can_embed_image(repo, fname.unicode): {{!embed_image_blob(repo, dirname.raw, fname.raw)}} % elif can_markdown(repo, fname.unicode): -{{!markdown_blob(blob)}} -% elif can_colorize(blob): -{{!colorize_blob(fname.unicode, blob)}} +{{!markdown_blob(blob.utf8_content)}} +% elif can_colorize(blob.utf8_content): +{{!colorize_blob(fname.unicode, blob.utf8_content)}} % else: <pre class="blob-body"> -{{blob}} +{{blob.utf8_content}} </pre> % end |